Bug 226285 – [Metal ANGLE] transformFeedback samples on webglsamples.org do not render correctly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Kyle Piddington]

[Metal ANGLE] transformFeedback samples on webglsamples.org do not render correctly

[Kyle Piddington]

Created attachment 429782 [details]
Patch

[Kyle Piddington]

<rdar://problem/78524773>

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Dean Jackson]

Pasting from an internal discussion (John Cunningham):

lgtm though I’d rather see memoryBarrier on macos if not difficult to add

on AGX macos it just ends and starts a new render pass anyways, but I think it is more efficient on nonagx

[Dean Jackson]

Comment on attachment 429782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review

> Source/ThirdParty/ANGLE/ChangeLog:11
> +        for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader.

typo transsform

[Alexey Proskuryakov]

Comment on attachment 429782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review

>> Source/ThirdParty/ANGLE/ChangeLog:11
>> +        for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader.
> 
> typo transsform

And seperated (found it at http://webglsamples.org/WebGL2Samples/#transform_feedback_separated_2)

[John Cunningham]

Comment on attachment 429782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review

Is the prepareForTransformFeedbackPassTwo not needed in drawTriFanArraysLegacy and drawLineLoopArrays

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:1405
> +void ContextMtl::onEndTransformFeedback(const gl::Context *context)

context isn't used in this function

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TransformFeedbackMtl.mm:96
> +    contextMtl->onEndTransformFeedback(context);

not needed if context isn't used in onEndTransformFeedback

[Kyle Piddington]

Created attachment 429936 [details]
Patch

[Kyle Piddington]

Created attachment 430054 [details]
Patch

[John Cunningham]

Comment on attachment 430054 [details]
Patch

LGTM

[EWS]

Committed r278335 (238368@main): <https://commits.webkit.org/238368@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430054 [details].