RESOLVED FIXED 226285
[Metal ANGLE] transformFeedback samples on webglsamples.org do not render correctly
https://bugs.webkit.org/show_bug.cgi?id=226285
Summary [Metal ANGLE] transformFeedback samples on webglsamples.org do not render cor...
Kyle Piddington
Reported 2021-05-26 12:31:15 PDT
[Metal ANGLE] transformFeedback samples on webglsamples.org do not render correctly
Attachments
Patch (7.37 KB, patch)
2021-05-26 12:34 PDT, Kyle Piddington
no flags
Patch (9.70 KB, patch)
2021-05-27 15:07 PDT, Kyle Piddington
no flags
Patch (8.29 KB, patch)
2021-05-28 14:41 PDT, Kyle Piddington
no flags
Kyle Piddington
Comment 1 2021-05-26 12:34:50 PDT
Kyle Piddington
Comment 2 2021-05-26 12:34:53 PDT
EWS Watchlist
Comment 3 2021-05-26 12:35:55 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Dean Jackson
Comment 4 2021-05-26 16:51:32 PDT
Pasting from an internal discussion (John Cunningham): lgtm though I’d rather see memoryBarrier on macos if not difficult to add on AGX macos it just ends and starts a new render pass anyways, but I think it is more efficient on nonagx
Dean Jackson
Comment 5 2021-05-26 16:52:26 PDT
Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review > Source/ThirdParty/ANGLE/ChangeLog:11 > + for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader. typo transsform
Alexey Proskuryakov
Comment 6 2021-05-26 17:13:32 PDT
Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review >> Source/ThirdParty/ANGLE/ChangeLog:11 >> + for transsform_feedback-seperated_2, we need to invalidate the current render pass descriptor in order to switch to the rasterizer-enabled version of the shader. > > typo transsform And seperated (found it at http://webglsamples.org/WebGL2Samples/#transform_feedback_separated_2)
John Cunningham
Comment 7 2021-05-26 18:10:40 PDT
Comment on attachment 429782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429782&action=review Is the prepareForTransformFeedbackPassTwo not needed in drawTriFanArraysLegacy and drawLineLoopArrays > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ContextMtl.mm:1405 > +void ContextMtl::onEndTransformFeedback(const gl::Context *context) context isn't used in this function > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TransformFeedbackMtl.mm:96 > + contextMtl->onEndTransformFeedback(context); not needed if context isn't used in onEndTransformFeedback
Kyle Piddington
Comment 8 2021-05-27 15:07:18 PDT
Kyle Piddington
Comment 9 2021-05-28 14:41:37 PDT
John Cunningham
Comment 10 2021-05-28 15:55:11 PDT
Comment on attachment 430054 [details] Patch LGTM
EWS
Comment 11 2021-06-01 18:01:14 PDT
Committed r278335 (238368@main): <https://commits.webkit.org/238368@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 430054 [details].
Note You need to log in before you can comment on or make changes to this bug.