WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226284
Unreviewed test gardening, remove some outdated test expectations.
https://bugs.webkit.org/show_bug.cgi?id=226284
Summary
Unreviewed test gardening, remove some outdated test expectations.
Arcady Goldmints-Orlov
Reported
2021-05-26 12:26:26 PDT
Unreviewed test gardening, remove some outdated test expectations.
Attachments
Patch
(2.71 KB, patch)
2021-05-26 12:26 PDT
,
Arcady Goldmints-Orlov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Arcady Goldmints-Orlov
Comment 1
2021-05-26 12:26:56 PDT
Created
attachment 429781
[details]
Patch
Alexey Proskuryakov
Comment 2
2021-05-26 17:09:30 PDT
Comment on
attachment 429781
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=429781&action=review
The change is good, however I think that commit queue won't be able to land it without "Unreviewed" line in the ChangeLog. Marking cq+ anyway for it to comment with some detail.
> LayoutTests/ChangeLog:3 > + Unreviewed test gardening, remove some outdated test expectations.
Checking one of these, I see that it progressed in
r277391
. I'm guessing that all of them did? It would be good to explain the history for anyone curious.
EWS
Comment 3
2021-05-26 17:41:01 PDT
Committed
r278142
(
238186@main
): <
https://commits.webkit.org/238186@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 429781
[details]
.
Radar WebKit Bug Importer
Comment 4
2021-05-26 17:42:16 PDT
<
rdar://problem/78542724
>
Alexey Proskuryakov
Comment 5
2021-05-26 21:21:24 PDT
I guess it doesn't need that now!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug