Bug 226284 - Unreviewed test gardening, remove some outdated test expectations.
Summary: Unreviewed test gardening, remove some outdated test expectations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 12:26 PDT by Arcady Goldmints-Orlov
Modified: 2021-05-26 21:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.71 KB, patch)
2021-05-26 12:26 PDT, Arcady Goldmints-Orlov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arcady Goldmints-Orlov 2021-05-26 12:26:26 PDT 
Unreviewed test gardening, remove some outdated test expectations.
Comment 1 Arcady Goldmints-Orlov 2021-05-26 12:26:56 PDT 
Created attachment 429781 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-05-26 17:09:30 PDT 
Comment on attachment 429781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429781&action=review

The change is good, however I think that commit queue won't be able to land it without "Unreviewed" line in the ChangeLog.

Marking cq+ anyway for it to comment with some detail.

> LayoutTests/ChangeLog:3
> +        Unreviewed test gardening, remove some outdated test expectations.

Checking one of these, I see that it progressed in r277391. I'm guessing that all of them did?

It would be good to explain the history for anyone curious.
Comment 3 EWS 2021-05-26 17:41:01 PDT 
Committed r278142 (238186@main): <https://commits.webkit.org/238186@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429781 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-26 17:42:16 PDT 
<rdar://problem/78542724>
Comment 5 Alexey Proskuryakov 2021-05-26 21:21:24 PDT 
I guess it doesn't need that now!