Bug 226280 - Next step toward using std::optional directly instead of through WTF::Optional typedef
Summary: Next step toward using std::optional directly instead of through WTF::Optiona...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 11:00 PDT by Darin Adler
Modified: 2021-05-27 18:27 PDT (History)
68 users (show)

See Also:

Attachments
Patch (2.41 MB, patch)
2021-05-26 21:54 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (2.41 MB, patch)
2021-05-26 22:26 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (2.44 MB, patch)
2021-05-27 09:30 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (2.48 MB, patch)
2021-05-27 14:54 PDT, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-05-26 11:00:17 PDT 
Next step toward using std::optional directly instead of through WTF::Optional typedef
Comment 1 Darin Adler 2021-05-26 21:54:08 PDT 
Created attachment 429844 [details]
Patch
Comment 2 Darin Adler 2021-05-26 22:26:00 PDT 
Created attachment 429845 [details]
Patch
Comment 3 EWS Watchlist 2021-05-26 22:27:44 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 Chris Dumez 2021-05-26 23:11:18 PDT 
Comment on attachment 429845 [details]
Patch

I see you couldn’t resist and did some refactoring in this already very large patch :) r=me once the bots are happy.
Comment 5 Darin Adler 2021-05-27 09:30:02 PDT 
Created attachment 429887 [details]
Patch
Comment 6 Darin Adler 2021-05-27 14:54:46 PDT 
Created attachment 429932 [details]
Patch
Comment 7 Darin Adler 2021-05-27 18:26:56 PDT 
Committed r278185 (238228@main): <https://commits.webkit.org/238228@main>
Comment 8 Radar WebKit Bug Importer 2021-05-27 18:27:24 PDT 
<rdar://problem/78598141>