Bug 226279 – Convert small JIT pool tests into executable fuzzing

• Status: REOPENED
• Component: New Bugs

[Keith Miller]

Convert small JIT pool tests into executable fuzzing

[Keith Miller]

Created attachment 429768 [details]
Patch

[Michael Saboff]

Comment on attachment 429768 [details]
Patch

r=me

[Keith Miller]

Created attachment 429770 [details]
Patch

[Keith Miller]

Created attachment 429773 [details]
Patch for landing

[EWS]

Tools/Scripts/svn-apply failed to apply attachment 429773 [details] to trunk.
Please resolve the conflicts and upload a new patch.

[Keith Miller]

Created attachment 430364 [details]
Patch for landing

[EWS]

Committed r278356 (238388@main): <https://commits.webkit.org/238388@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430364 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78767508>

[WebKit Commit Bot]

Re-opened since this is blocked by bug 226606

[Keith Miller]

Created attachment 433516 [details]
Patch for landing

[EWS]

Committed r279916 (239665@main): <https://commits.webkit.org/239665@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 433516 [details].

[Saam Barati]

Comment on attachment 433516 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=433516&action=review

We also are using the random executable allocation fuzzer for all our tests now: https://trac.webkit.org/changeset/279126/webkit

> Source/JavaScriptCore/jit/ExecutableAllocationFuzz.cpp:44
> +    static WeakRandom random(Options::seedOfVMRandomForFuzzer() ? Options::seedOfVMRandomForFuzzer() : cryptographicallyRandomNumber());

Why is this defined right here? Maybe we can unify w/ WeakRandom below? Kinda confusing to put this definition here and not use it until way later.

I think this should also be a LazyNeverDestroyed like below?

Maybe also should use a lock like below?

[WebKit Commit Bot]

Re-opened since this is blocked by bug 228037