Bug 226275 – #ifdef out transformToColorSpace() in ImageBuffer and subclasses to make it clear it is only needed for non-CG ports

• Status: NEW
• Component: Platform

[Sam Weinig]

We currently have no-op implementations of transformToColorSpace() in ImageBuffer and its CG subclasses. I think we should make it clear it is not intended to work for CG by making it impossible to call via #ifdef.

[Sam Weinig]

Really, we should have a better macro for this. Maybe ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE?

[Sam Weinig]

ENABLE_IMAGE_BUFFER_SUPPORTS_COLOR_SPACE is not great, because it will be really confusing to see:

#if !ENABLE(IMAGE_BUFFER_SUPPORTS_COLOR_SPACE)
    maskerData->maskImage->transformToColorSpace(colorSpace);
#endif

Perhaps the real answer is that we need to replace transformToColorSpace() with something that makes it clear it is not really correct. Like a function that just does a getPixelBuffer -> colorSpace transformation > setPixelBuffer(), though that would obviously be less efficient so not a good idea.

[Radar WebKit Bug Importer]

<rdar://problem/78765976>