Bug 226269 - [LFC] Introduce containingBlockChain iterator
Summary: [LFC] Introduce containingBlockChain iterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 07:58 PDT by zalan
Modified: 2021-05-26 09:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (10.91 KB, patch)
2021-05-26 08:04 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.84 KB, patch)
2021-05-26 08:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.85 KB, patch)
2021-05-26 08:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-05-26 07:58:01 PDT 
Iterator for the containing block chain
Comment 1 zalan 2021-05-26 08:04:48 PDT 
Created attachment 429758 [details]
Patch
Comment 2 Antti Koivisto 2021-05-26 08:10:04 PDT 
Comment on attachment 429758 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429758&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingQuirks.cpp:70
> +    for (auto& ancestor : containingBlockChainOf(layoutBox)) {

Not sure if the "Of" adds anything.

> Source/WebCore/layout/layouttree/LayoutContainingBlockChainIterator.h:54
> +    LayoutContainingBlockChainIterator begin() { return LayoutContainingBlockChainIterator(m_containingBlock); }
> +    LayoutContainingBlockChainIterator end() { return LayoutContainingBlockChainIterator(); }

could be 

auto begin()
auto end()
Comment 3 zalan 2021-05-26 08:18:42 PDT 
Created attachment 429760 [details]
Patch
Comment 4 zalan 2021-05-26 08:19:37 PDT 
Created attachment 429761 [details]
Patch
Comment 5 EWS 2021-05-26 09:30:30 PDT 
Committed r278086 (238163@main): <https://commits.webkit.org/238163@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429761 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-26 09:31:23 PDT 
<rdar://problem/78516872>