Bug 226262 - ANGLE Metal translator pre-rotation code is unused and it asserts when used
Summary: ANGLE Metal translator pre-rotation code is unused and it asserts when used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 02:42 PDT by Kimmo Kinnunen
Modified: 2021-06-01 01:02 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.77 KB, patch)
2021-05-26 02:47 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (7.14 KB, patch)
2021-05-26 04:18 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff
Patch (11.04 KB, patch)
2021-05-27 03:22 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-05-26 02:42:45 PDT
ANGLE Metal translator pre-rotation code is unused and buggy

It is unused and most likely not neededed.
It asserts when used.
Comment 1 Kimmo Kinnunen 2021-05-26 02:47:12 PDT
Created attachment 429742 [details]
Patch
Comment 2 EWS Watchlist 2021-05-26 02:48:15 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Kimmo Kinnunen 2021-05-26 04:18:11 PDT
Created attachment 429746 [details]
Patch
Comment 4 John Cunningham 2021-05-26 18:32:44 PDT
Comment on attachment 429746 [details]
Patch

The DriverUniforms struct needs updating as well to reflect these changes in ContextMtl.h, apart from that it LGTM.
Comment 5 Kimmo Kinnunen 2021-05-27 03:22:00 PDT
Created attachment 429864 [details]
Patch
Comment 6 John Cunningham 2021-05-27 11:26:35 PDT
Comment on attachment 429864 [details]
Patch

LGTM
Comment 7 EWS 2021-06-01 01:01:51 PDT
Committed r278298 (238335@main): <https://commits.webkit.org/238335@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429864 [details].
Comment 8 Radar WebKit Bug Importer 2021-06-01 01:02:17 PDT
<rdar://problem/78703256>