Bug 226261 - ANGLE Metal translator should always collect variables
Summary: ANGLE Metal translator should always collect variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-26 02:26 PDT by Kimmo Kinnunen
Modified: 2021-05-28 00:16 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.90 KB, patch)
2021-05-26 02:32 PDT, Kimmo Kinnunen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-05-26 02:26:00 PDT
ANGLE Metal translator should always collect variables

RemoveInactiveInterfaceVariables helper function needs the variables to be collected.

Normal operation invokes this as a side-effect of passing SH_VARIABLES compile option. 

However, some tests might not pass the compile option, but Metal translator still removes the inactive interface variables.

Thus we need to always collect the variables.
Comment 1 Kimmo Kinnunen 2021-05-26 02:32:20 PDT
Created attachment 429741 [details]
Patch
Comment 2 EWS Watchlist 2021-05-26 02:33:11 PDT
Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 John Cunningham 2021-05-26 18:30:43 PDT
Comment on attachment 429741 [details]
Patch

LGTM
Comment 4 EWS 2021-05-28 00:15:50 PDT
Committed r278192 (238235@main): <https://commits.webkit.org/238235@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429741 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-28 00:16:20 PDT
<rdar://problem/78607455>