Bug 226252 - Use `NSLocale` SPI for comparing language identifiers instead of string comparison
Summary: Use `NSLocale` SPI for comparing language identifiers instead of string compa...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-25 17:22 PDT by Devin Rousso
Modified: 2021-05-27 10:55 PDT (History)
14 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2021-05-25 17:27 PDT, Devin Rousso 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2021-05-26 20:17 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (6.51 KB, patch)
2021-05-26 20:40 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-05-25 17:22:08 PDT 
.
Comment 1 Devin Rousso 2021-05-25 17:27:30 PDT 
Created attachment 429715 [details]
Patch
Comment 2 Alexey Proskuryakov 2021-05-25 18:18:03 PDT 
Comment on attachment 429715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429715&action=review

> Source/WTF/ChangeLog:4
> +        Use `NSLocale` SPI for comparing language identifiers instead of string comparison
> +        https://bugs.webkit.org/show_bug.cgi?id=226252

A "why" comment would be very useful here.
Comment 3 Devin Rousso 2021-05-26 20:17:13 PDT 
Created attachment 429834 [details]
Patch
Comment 4 Devin Rousso 2021-05-26 20:40:52 PDT 
Created attachment 429837 [details]
Patch
Comment 5 EWS 2021-05-27 10:54:22 PDT 
Committed r278168 (238212@main): <https://commits.webkit.org/238212@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429837 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-27 10:55:19 PDT 
<rdar://problem/78576565>