Bug 226250 - Stop using UncheckedLock in MediaElementAudioSourceNode
Summary: Stop using UncheckedLock in MediaElementAudioSourceNode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2021-05-25 16:37 PDT by Chris Dumez
Modified: 2021-05-25 22:01 PDT (History)
16 users (show)

See Also:

Patch (3.88 KB, patch)
2021-05-25 17:24 PDT, Chris Dumez
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-25 16:37:51 PDT
Stop using UncheckedLock in MediaElementAudioSourceNode as it is being phased out in favor of Lock, which supports clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-25 17:24:43 PDT
Created attachment 429714 [details]
Comment 2 Darin Adler 2021-05-25 20:39:00 PDT
Comment on attachment 429714 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=429714&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:6635
> +    Optional<Locker<Lock>> audioSourceNodeLocker;

In new code you should write std::optional, not Optional.
Comment 3 Chris Dumez 2021-05-25 22:00:55 PDT
Committed r278077 (238156@main): <https://commits.webkit.org/238156@main>
Comment 4 Radar WebKit Bug Importer 2021-05-25 22:01:21 PDT