RESOLVED FIXED 226249
[GStreamer] Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer 
https://bugs.webkit.org/show_bug.cgi?id=226249
Summary [GStreamer] Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer
Chris Dumez
Reported 2021-05-25 16:31:28 PDT
Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer as it is being phased out in favor of WTF::Lock, which supports Clang thread safety analysis.
Attachments
Patch (6.58 KB, patch)
2021-05-25 16:33 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.58 KB, patch)
2021-05-25 17:02 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (6.56 KB, patch)
2021-05-25 17:38 PDT, Chris Dumez 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-25 16:33:32 PDT
Created attachment 429710 [details] Patch
Chris Dumez
Comment 2 2021-05-25 17:02:09 PDT
Created attachment 429712 [details] Patch
Chris Dumez
Comment 3 2021-05-25 17:38:34 PDT
Created attachment 429717 [details] Patch
Darin Adler
Comment 4 2021-05-25 20:37:59 PDT
Comment on attachment 429717 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=429717&action=review > Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:207 > + // Note that waitFor() releases the lock lock internally while it waits, so isFlushing may have been changed. "the lock lock"?
Chris Dumez
Comment 5 2021-05-25 21:58:34 PDT
Committed r278075 (238154@main): <https://commits.webkit.org/238154@main>
Note You need to log in before you can comment on or make changes to this bug.