Bug 226249 - [GStreamer] Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer
Summary: [GStreamer] Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 226212
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-25 16:31 PDT by Chris Dumez
Modified: 2021-05-25 21:59 PDT (History)
13 users (show)

See Also:

Attachments
Patch (6.58 KB, patch)
2021-05-25 16:33 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.58 KB, patch)
2021-05-25 17:02 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.56 KB, patch)
2021-05-25 17:38 PDT, Chris Dumez 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-25 16:31:28 PDT 
Stop using UncheckedLock in WebKitCommonEncryptionDecryptorGStreamer as it is being phased out in favor of WTF::Lock, which supports Clang thread safety analysis.
Comment 1 Chris Dumez 2021-05-25 16:33:32 PDT 
Created attachment 429710 [details]
Patch
Comment 2 Chris Dumez 2021-05-25 17:02:09 PDT 
Created attachment 429712 [details]
Patch
Comment 3 Chris Dumez 2021-05-25 17:38:34 PDT 
Created attachment 429717 [details]
Patch
Comment 4 Darin Adler 2021-05-25 20:37:59 PDT 
Comment on attachment 429717 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429717&action=review

> Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:207
> +        // Note that waitFor() releases the lock lock internally while it waits, so isFlushing may have been changed.

"the lock lock"?
Comment 5 Chris Dumez 2021-05-25 21:58:34 PDT 
Committed r278075 (238154@main): <https://commits.webkit.org/238154@main>