Bug 226235 - Warn when running build-webkit with unaligned Xcode release
Summary: Warn when running build-webkit with unaligned Xcode release
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 232606 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-25 12:59 PDT by Sam Sneddon [:gsnedders]
Modified: 2023-09-26 08:55 PDT (History)
7 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-05-25 12:59:02 PDT
We don't have any bots checking e.g. Xcode 12 (macOS 11 aligned release) building with the macOS 10.15 SDK and typically such configurations fail. We should make build-webkit fail and document this so people stop questioning what they're missing when they run into build errors.
Comment 1 Alexey Proskuryakov 2021-05-25 18:27:11 PDT
Xcode 12 with the macOS 10.15 SDK is not a configuration that can be installed directly, this can only happen through hacking pieces together manually.

There is a related issue that you may have had in mind though. Installing Xcode 12 with its macOS 11 SDK on macOS 10.15.x is in fact normal, and that's what we don't test for in CI at all.
Comment 2 Sam Sneddon [:gsnedders] 2021-05-26 06:50:40 PDT
Oh, I thought installing Xcode from the Mac App Store always installed the SDK for the currently installed OS as well as potentially any newer OS SDK!

Regardless, the fundamental problem here is that we neither support nor document our lack of support for misaligned OS/Xcode releases.
Comment 3 Alexey Proskuryakov 2021-05-26 10:10:20 PDT
Yes, this is definitely a problem. It is super painful, because we should support this very reasonable configuration that people may already have on their machines, but it would be costly because we don't need it for anything that ships.

As long as we don't support it, warning makes sense, and it would also be helpful to have it explained at <https://webkit.org/build-tools/>.
Comment 4 Radar WebKit Bug Importer 2021-06-01 12:59:17 PDT
<rdar://problem/78728355>
Comment 5 Darryl Pogue 2021-10-29 10:23:06 PDT
*** Bug 232454 has been marked as a duplicate of this bug. ***
Comment 6 Sergio Villar Senin 2021-11-02 06:38:24 PDT
I am unable to build at the moment with MacOS 11.6 and Xcode 12.2 which from what I've read should be supported. This is what I get

In file included from /Users/svillar/WebKit/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:37:                                                                                       
/Users/svillar/WebKit/WebKitBuild/Debug/usr/local/include/pal/cocoa/AVFoundationSoftLink.h:51:33: error: 'AVDelegatingPlaybackCoordinator' is only available on macOS                      
      12.0 or newer [-Werror,-Wunguarded-availability-new]                                                                                                                                 
SOFT_LINK_CLASS_FOR_HEADER(PAL, AVDelegatingPlaybackCoordinator)                                                                                                                           
                                ^                                                                                                                                                          
In file included from /Users/svillar/WebKit/Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:37:                                                                                       
In file included from /Users/svillar/WebKit/WebKitBuild/Debug/usr/local/include/pal/cocoa/AVFoundationSoftLink.h:30:                                                                       
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVFoundat
ion.h:13:                                                                                                                                                                                  
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVFCore.h
:56:                                                                                                                                                                                       
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVPlaybackCoordinator.h:315:12:
 note:                                                                                                                                                                                     
      'AVDelegatingPlaybackCoordinator' has been marked as being introduced in macOS 12.0 here, but the deployment target is macOS 11.0.0                                                  
@interface AVDelegatingPlaybackCoordinator : AVPlaybackCoordinator
Comment 7 Alexey Proskuryakov 2021-11-02 08:33:02 PDT
This log says that you have macOS 12 SDK, but Xcode 12.2 wouldn't include that. Did you copy the SDK manually into it, or do you actually have Xcode 13, the newest?
Comment 8 Sergio Villar Senin 2021-11-02 09:51:18 PDT
(In reply to Alexey Proskuryakov from comment #7)
> This log says that you have macOS 12 SDK, but Xcode 12.2 wouldn't include
> that. Did you copy the SDK manually into it, or do you actually have Xcode
> 13, the newest?

Yep, sorry for the noise. I actually have both, so I guess the xcode-select will make the trick. Do you know if this is a global or per-user setting?
Comment 9 Alexey Proskuryakov 2021-11-02 10:07:34 PDT
Sorry, I do not know that.
Comment 10 Sam Sneddon [:gsnedders] 2021-11-08 08:08:48 PST
*** Bug 232606 has been marked as a duplicate of this bug. ***