Bug 226234 - [run-webkit-tests] Use webkitcorepy's TaskPool
Summary: [run-webkit-tests] Use webkitcorepy's TaskPool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-25 12:56 PDT by Jonathan Bedard
Modified: 2021-06-04 07:04 PDT (History)
4 users (show)

See Also:

Attachments
Patch (29.83 KB, patch)
2021-06-02 14:34 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (30.01 KB, patch)
2021-06-02 16:42 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (29.98 KB, patch)
2021-06-03 15:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-05-25 12:56:01 PDT 
In order to support Python 3, run-webkit-tests needs to use webkitcorepy's TaskPool for multiprocessing.
Comment 1 Radar WebKit Bug Importer 2021-05-25 12:56:39 PDT 
<rdar://problem/78471695>
Comment 2 Jonathan Bedard 2021-06-02 14:34:34 PDT 
Created attachment 430407 [details]
Patch
Comment 3 Jonathan Bedard 2021-06-02 16:42:33 PDT 
Created attachment 430418 [details]
Patch
Comment 4 dewei_zhu 2021-06-03 14:52:16 PDT 
Comment on attachment 430418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430418&action=review

r=me

> Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:154
> +        self.printer.write_update('Starting %s ...' % pluralize(num_workers, "worker"))

Use formatted string?
Comment 5 Jonathan Bedard 2021-06-03 15:01:27 PDT 
Created attachment 430503 [details]
Patch
Comment 6 EWS 2021-06-04 07:04:42 PDT 
Committed r278454 (238474@main): <https://commits.webkit.org/238474@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430503 [details].