Bug 226225 - [AppleWin] JSC fails to build
Summary: [AppleWin] JSC fails to build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-25 10:08 PDT by Per Arne Vollan
Modified: 2021-05-25 12:12 PDT (History)
10 users (show)

See Also:


Attachments
Patch (1.46 KB, patch)
2021-05-25 10:12 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-05-25 10:08:10 PDT
JSC fails to build on AppleWin with the following error:

/usr/bin/ruby: No such file or directory -- include/private/WTF/Scripts/generate-unified-source-bundles.
rb (LoadError)
Comment 1 Per Arne Vollan 2021-05-25 10:08:30 PDT
<rdar://78330435>
Comment 2 Per Arne Vollan 2021-05-25 10:12:29 PDT
Created attachment 429663 [details]
Patch
Comment 3 Brent Fulgham 2021-05-25 11:08:23 PDT
Comment on attachment 429663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429663&action=review

r=me

> Source/WTF/wtf/CMakeLists.txt:-588
> -)

It seems like you could keep this variable and leave the COPY command as it is, with the only change being the command to create the directory (and the new log message).
Comment 4 Per Arne Vollan 2021-05-25 11:39:53 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 429663 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429663&action=review
> 
> r=me
> 
> > Source/WTF/wtf/CMakeLists.txt:-588
> > -)
> 
> It seems like you could keep this variable and leave the COPY command as it
> is, with the only change being the command to create the directory (and the
> new log message).

That is a good point. This change is basically a revert of a recent change, so I was thinking we could try this out, in case that recent change introduced the issue.

Thanks for reviewing!
Comment 5 EWS 2021-05-25 12:12:29 PDT
Committed r278032 (238129@main): <https://commits.webkit.org/238129@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429663 [details].