Bug 226208 - Stop using UncheckedLock in DatabaseTracker
Summary: Stop using UncheckedLock in DatabaseTracker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 19:32 PDT by Chris Dumez
Modified: 2021-05-25 08:27 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.30 KB, patch)
2021-05-24 19:35 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.62 KB, patch)
2021-05-24 20:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-24 19:32:36 PDT 
Stop using UncheckedLock in DatabaseTracker.
Comment 1 Chris Dumez 2021-05-24 19:35:43 PDT 
Created attachment 429613 [details]
Patch
Comment 2 Sam Weinig 2021-05-24 20:11:20 PDT 
Comment on attachment 429613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429613&action=review

> Source/WebCore/ChangeLog:14
> +        In this particular instance, I have opted to annotate the functions that gave out
> +        warning with WTF_IGNORES_THREAD_SAFETY_ANALYSIS. I initially tried to use proper
> +        annotations (WTF_ACQUIRES_LOCK() / WTF_RELEASES_LOCK()). However, the call sites are
> +        Objective C functions and I am unable to annotate those.

I think adding a comment to the code explaining this would be helpful for future readers.
Comment 3 Chris Dumez 2021-05-24 20:13:50 PDT 
Created attachment 429619 [details]
Patch
Comment 4 EWS 2021-05-25 08:26:54 PDT 
Committed r278008 (238121@main): <https://commits.webkit.org/238121@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429619 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-25 08:27:19 PDT 
<rdar://problem/78457503>