WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
226206
Stop using UncheckedLock in WTF::RecursiveLock
https://bugs.webkit.org/show_bug.cgi?id=226206
Summary
Stop using UncheckedLock in WTF::RecursiveLock
Chris Dumez
Reported
2021-05-24 19:10:22 PDT
Stop using UncheckedLock in WTF::RecursiveLock and use a regular Lock instead. This is a step towards phasing out UncheckedLock.
Attachments
Patch
(2.03 KB, patch)
2021-05-24 19:12 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(2.94 KB, patch)
2021-05-24 20:20 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2021-05-24 19:12:53 PDT
Created
attachment 429611
[details]
Patch
Sam Weinig
Comment 2
2021-05-24 20:13:10 PDT
Comment on
attachment 429611
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=429611&action=review
> Source/WTF/wtf/RecursiveLockAdapter.h:38 > + void lock() WTF_IGNORES_THREAD_SAFETY_ANALYSIS
I think a comment explaining why this is being added would go a long way here.
Chris Dumez
Comment 3
2021-05-24 20:20:28 PDT
Created
attachment 429620
[details]
Patch
EWS
Comment 4
2021-05-24 20:59:56 PDT
Committed
r277995
(
238108@main
): <
https://commits.webkit.org/238108@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 429620
[details]
.
Radar WebKit Bug Importer
Comment 5
2021-05-24 21:00:18 PDT
<
rdar://problem/78434523
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug