Bug 226206 - Stop using UncheckedLock in WTF::RecursiveLock
Summary: Stop using UncheckedLock in WTF::RecursiveLock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 19:10 PDT by Chris Dumez
Modified: 2021-05-24 21:00 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.03 KB, patch)
2021-05-24 19:12 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.94 KB, patch)
2021-05-24 20:20 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-24 19:10:22 PDT 
Stop using UncheckedLock in WTF::RecursiveLock and use a regular Lock instead. This is a step towards phasing out UncheckedLock.
Comment 1 Chris Dumez 2021-05-24 19:12:53 PDT 
Created attachment 429611 [details]
Patch
Comment 2 Sam Weinig 2021-05-24 20:13:10 PDT 
Comment on attachment 429611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429611&action=review

> Source/WTF/wtf/RecursiveLockAdapter.h:38
> +    void lock() WTF_IGNORES_THREAD_SAFETY_ANALYSIS

I think a comment explaining why this is being added would go a long way here.
Comment 3 Chris Dumez 2021-05-24 20:20:28 PDT 
Created attachment 429620 [details]
Patch
Comment 4 EWS 2021-05-24 20:59:56 PDT 
Committed r277995 (238108@main): <https://commits.webkit.org/238108@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429620 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-24 21:00:18 PDT 
<rdar://problem/78434523>