Bug 226205 - Raise jitMemoryReservationSize for ftl-no-cjit-small-pool* tests.
Summary: Raise jitMemoryReservationSize for ftl-no-cjit-small-pool* tests.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 18:44 PDT by Mark Lam
Modified: 2021-05-25 16:56 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch. (2.33 KB, patch)
2021-05-24 18:47 PDT, Mark Lam
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-05-24 18:44:33 PDT
Raise jitMemoryReservationSize for ftl-no-cjit-small-pool* tests from 50000 to 75000.  The 50000 number was picked years ago to be a size that is small, but is still large enough for JSC tests to pass.  50000 appears to not be sufficient anymore.  This has caused some JSC tests to fail intermittently on the EWS bots.

Raising the size to 75000 to give the tests a little more room to work in.
Comment 1 Mark Lam 2021-05-24 18:47:00 PDT
Created attachment 429606 [details]
proposed patch.
Comment 2 Mark Lam 2021-05-24 20:01:28 PDT
Thanks for the review.  Landed in r277989: <http://trac.webkit.org/r277989>.
Comment 3 Radar WebKit Bug Importer 2021-05-24 20:02:16 PDT
<rdar://problem/78432330>
Comment 4 Mark Lam 2021-05-25 16:47:05 PDT
Apparently 75K still isn't enough and the jsc EWS bot is still in pain.  I'm going to bump it to 100k.
Comment 5 Mark Lam 2021-05-25 16:54:12 PDT
Bumped to 102400 (100k).

Landed in r278061: <http://trac.webkit.org/r278061>.