Bug 226199 – [iOS] Adjust meaningful click heuristic to detect focus changes and editable content

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

rdar://78368624

[Wenson Hsieh]

Created attachment 429593 [details]
Patch

[Wenson Hsieh]

Created attachment 429595 [details]
Patch

[Tim Horton]

Comment on attachment 429595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429595&action=review

> Source/WebKit/ChangeLog:16
> +        Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately
> +        dismissing the keyboard after the tap.

This feels a bit like tuning the heuristic to a particular use of it, instead of something that would actually make the click non-meaningful?

[Wenson Hsieh]

(In reply to Tim Horton from comment #3)
> Comment on attachment 429595 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429595&action=review
> 
> > Source/WebKit/ChangeLog:16
> > +        Additionally, avoid dispatching this message when the keyboard is shown, such that we won't end up immediately
> > +        dismissing the keyboard after the tap.
> 
> This feels a bit like tuning the heuristic to a particular use of it,
> instead of something that would actually make the click non-meaningful?

That's true! I'll remove this bit.

[Wenson Hsieh]

Created attachment 429597 [details]
Patch

[EWS]

Committed r277990 (238103@main): <https://commits.webkit.org/238103@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429597 [details].