Bug 226197 - [PlayStation] Implement FileSystem without std::filesystem
Summary: [PlayStation] Implement FileSystem without std::filesystem
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
Keywords: InRadar
Depends on:
Reported: 2021-05-24 16:19 PDT by Don Olmstead
Modified: 2021-05-25 10:35 PDT (History)
13 users (show)

See Also:

Patch (19.41 KB, patch)
2021-05-24 16:32 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (19.42 KB, patch)
2021-05-24 16:38 PDT, Don Olmstead
cdumez: review+
Details | Formatted Diff | Diff
Patch (19.31 KB, patch)
2021-05-25 08:37 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-05-24 16:19:24 PDT
The PlayStation 4 doesn't have std::filesystem support currently so bring back the POSIX implementations.
Comment 1 Don Olmstead 2021-05-24 16:32:15 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-05-24 16:38:01 PDT
Created attachment 429589 [details]

Make style checker happy
Comment 3 Christopher Reid 2021-05-24 16:52:34 PDT
Comment on attachment 429588 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=429588&action=review

Just have an informal comment

> Source/WTF/wtf/playstation/FileSystemPlayStation.cpp:38
> +#include <fnmatch.h>

fnmatch.h looks like it isn't needed now
Comment 4 Chris Dumez 2021-05-24 16:54:13 PDT
Comment on attachment 429589 [details]

r=me if the bots are happy.
Comment 5 Don Olmstead 2021-05-25 08:37:09 PDT
Created attachment 429654 [details]

Added implementation for isHidden and got rid of unused includes.
Comment 6 EWS 2021-05-25 10:34:11 PDT
Committed r278027 (238124@main): <https://commits.webkit.org/238124@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429654 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-25 10:35:22 PDT