Bug 226196 - When running with --reportTotalPhaseTimes=1, we should also log the max time in a phase
Summary: When running with --reportTotalPhaseTimes=1, we should also log the max time ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 16:11 PDT by Robin Morisset
Modified: 2021-05-24 17:04 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2021-05-24 16:13 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2021-05-24 16:11:04 PDT 
When seeing that we spend a lot of time in a given phase, it can be helpful to know whether it is because of an outlier or not.
It matters especially for the DFG, as the GC is stopped whenever a DFG phase is running.
Comment 1 Robin Morisset 2021-05-24 16:13:28 PDT 
Created attachment 429584 [details]
Patch
Comment 2 EWS 2021-05-24 17:03:54 PDT 
Committed r277984 (238097@main): <https://commits.webkit.org/238097@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429584 [details].
Comment 3 Radar WebKit Bug Importer 2021-05-24 17:04:34 PDT 
<rdar://problem/78426364>