Bug 226190 - [GLIB] Stop using UncheckedLock in IconDatabase
Summary: [GLIB] Stop using UncheckedLock in IconDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-24 15:12 PDT by Chris Dumez
Modified: 2021-05-24 20:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2021-05-24 15:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (4.69 KB, patch)
2021-05-24 15:44 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (4.65 KB, patch)
2021-05-24 16:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-24 15:12:48 PDT 
Stop using UncheckedLock in IconDatabase to benefit from Clang thread-safety analysis.
Comment 1 Chris Dumez 2021-05-24 15:13:58 PDT 
Created attachment 429571 [details]
Patch
Comment 2 EWS Watchlist 2021-05-24 15:14:40 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2021-05-24 15:44:35 PDT 
Created attachment 429577 [details]
Patch
Comment 4 Chris Dumez 2021-05-24 16:58:09 PDT 
Created attachment 429592 [details]
Patch
Comment 5 EWS 2021-05-24 20:13:47 PDT 
Committed r277991 (238104@main): <https://commits.webkit.org/238104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429592 [details].