Bug 226184 - Remove deprecated API usage in PageClientImplMac
Summary: Remove deprecated API usage in PageClientImplMac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 12:33 PDT by Aditya Keerthi
Modified: 2021-05-24 16:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2021-05-24 14:03 PDT, Dana Estra 		no flags Details | Formatted Diff | Diff
Removed deprecated API usage in PageClientImplMac and implemented edit from review (1.91 KB, patch)
2021-05-24 15:48 PDT, Dana Estra 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-05-24 12:33:52 PDT 
`[NSWindow convertScreenToBase:]` and `[NSWindow convertBaseToScreen:]` have been deprecated since macOS 10.7.
Comment 1 Dana Estra 2021-05-24 14:03:46 PDT 
Created attachment 429561 [details]
Patch
Comment 2 Devin Rousso 2021-05-24 14:17:32 PDT 
Comment on attachment 429561 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429561&action=review

r=me, nice!

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:447
> +    NSPoint windowCoord = [[m_view window] convertPointFromScreen:point];

NIT: I think you can `m_view.window` :)

> Source/WebKit/UIProcess/mac/PageClientImplMac.mm:455
> +    tempRect.origin = [[m_view window] convertPointToScreen:tempRect.origin];

ditto (:447)
Comment 3 Dana Estra 2021-05-24 15:48:59 PDT 
Created attachment 429579 [details]
Removed deprecated API usage in PageClientImplMac and implemented edit from review
Comment 4 EWS 2021-05-24 16:47:35 PDT 
Committed r277983 (238096@main): <https://commits.webkit.org/238096@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429579 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-24 16:48:20 PDT 
<rdar://problem/78425683>