Bug 226165 - [CoordinatedGraphics] Handle null native surface handle for surfaceless rendering
Summary: [CoordinatedGraphics] Handle null native surface handle for surfaceless rende...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-24 00:36 PDT by Zan Dobersek
Modified: 2021-05-24 23:15 PDT (History)
10 users (show)

See Also:

Attachments
Patch (2.84 KB, patch)
2021-05-24 00:42 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2021-05-24 00:36:49 PDT 
[CoordinatedGraphics] Handle null native window handle for surfaceless rendering
Comment 1 Zan Dobersek 2021-05-24 00:42:31 PDT 
Created attachment 429509 [details]
Patch
Comment 2 Philippe Normand 2021-05-24 08:20:10 PDT 
Comment on attachment 429509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429509&action=review

> Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:74
> +        if (m_context) {

Nit: this could be reversed and early return.
Comment 3 EWS 2021-05-24 23:14:53 PDT 
Committed r277998 (238111@main): <https://commits.webkit.org/238111@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429509 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-24 23:15:19 PDT 
<rdar://problem/78439250>