Bug 226155 - Remove some now invalid tests in testmasm.
Summary: Remove some now invalid tests in testmasm.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-23 08:35 PDT by Mark Lam
Modified: 2021-05-23 22:01 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (2.53 KB, patch)
2021-05-23 08:38 PDT, Mark Lam 		ysuzuki: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-05-23 08:35:34 PDT 
The ARM64E tests were checking that cageConditionallyAndUntag() would fail to produce a caged pointer if fed invalid values.  These tests are no longer feasible because on ARM64E, feeding cageConditionallyAndUntag() invalid values will now result in a crash.  This patch removes these tests.
Comment 1 Mark Lam 2021-05-23 08:38:18 PDT 
Created attachment 429465 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2021-05-23 21:21:20 PDT 
Comment on attachment 429465 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review

r=me

> Source/JavaScriptCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :)
Comment 3 Mark Lam 2021-05-23 21:53:02 PDT 
Comment on attachment 429465 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=429465&action=review

Thanks for the review.

>> Source/JavaScriptCore/ChangeLog:6
>> +        Reviewed by NOBODY (OOPS!).
> 
> Let’s add description that is pasted in the bugzilla. That is helpful to folks who will see this patch later :)

Oops.  Will do.
Comment 4 Mark Lam 2021-05-23 22:00:18 PDT 
Landed in r277942: <http://trac.webkit.org/r277942>.
Comment 5 Radar WebKit Bug Importer 2021-05-23 22:01:21 PDT 
<rdar://problem/78384961>