Bug 226152 - Use CheckedLock in even more places
Summary: Use CheckedLock in even more places
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 226157
  Show dependency tree / graph
 
Reported: 2021-05-22 21:37 PDT by Chris Dumez
Modified: 2021-05-23 13:34 PDT (History)
22 users (show)

See Also:

Attachments
Patch (45.83 KB, patch)
2021-05-22 21:39 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (45.80 KB, patch)
2021-05-22 21:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (46.02 KB, patch)
2021-05-23 13:03 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.02 KB, patch)
2021-05-23 13:12 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (46.05 KB, patch)
2021-05-23 13:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-22 21:37:08 PDT 
Use CheckedCondition in even more places to benefit from Clang Thread Safety Analysis.
Comment 1 Chris Dumez 2021-05-22 21:39:48 PDT 
Created attachment 429454 [details]
Patch
Comment 2 Chris Dumez 2021-05-22 21:42:02 PDT 
Created attachment 429455 [details]
Patch
Comment 3 Darin Adler 2021-05-23 12:46:22 PDT 
Comment on attachment 429455 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429455&action=review

> Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:373
> +// FIXME: This modifies m_data without grabbing m_dataLock.

Hard to fix?

> Source/WebCore/worklets/PaintWorkletGlobalScope.h:68
> +    HashMap<String, std::unique_ptr<PaintDefinition>>& paintDefinitionMap() WTF_REQUIRES_LOCK(m_paintDefinitionLock)
> +    {
> +        ASSERT(m_paintDefinitionLock.isLocked());
> +        return m_paintDefinitionMap;
> +    }

Can we put this function body after the class definition to keep the class definition easy to read?
Comment 4 Chris Dumez 2021-05-23 13:00:28 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 429455 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429455&action=review
> 
> > Source/WebCore/platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:373
> > +// FIXME: This modifies m_data without grabbing m_dataLock.
> 
> Hard to fix?

I will check in a follow-up. I decided to stay away from fixes in my large refactoring fixes based on earlier feedback.

> 
> > Source/WebCore/worklets/PaintWorkletGlobalScope.h:68
> > +    HashMap<String, std::unique_ptr<PaintDefinition>>& paintDefinitionMap() WTF_REQUIRES_LOCK(m_paintDefinitionLock)
> > +    {
> > +        ASSERT(m_paintDefinitionLock.isLocked());
> > +        return m_paintDefinitionMap;
> > +    }
> 
> Can we put this function body after the class definition to keep the class
> definition easy to read?

Will fix.
Comment 5 Chris Dumez 2021-05-23 13:03:18 PDT 
Created attachment 429471 [details]
Patch
Comment 6 Chris Dumez 2021-05-23 13:12:05 PDT 
Created attachment 429474 [details]
Patch
Comment 7 Chris Dumez 2021-05-23 13:18:07 PDT 
Created attachment 429475 [details]
Patch
Comment 8 Chris Dumez 2021-05-23 13:33:36 PDT 
Comment on attachment 429475 [details]
Patch

Clearing flags on attachment: 429475

Committed r277934 (238064@main): <https://commits.webkit.org/238064@main>
Comment 9 Chris Dumez 2021-05-23 13:33:40 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2021-05-23 13:34:17 PDT 
<rdar://problem/78372445>