Bug 226150 - [LFC] Add support for geometry/quirks virtual functions
Summary: [LFC] Add support for geometry/quirks virtual functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-22 21:15 PDT by zalan
Modified: 2021-05-24 17:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (86.39 KB, patch)
2021-05-22 21:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (49.27 KB, patch)
2021-05-23 07:06 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (77.22 KB, patch)
2021-05-24 12:59 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-05-22 21:15:45 PDT 
ssia
Comment 1 zalan 2021-05-22 21:18:07 PDT 
Created attachment 429452 [details]
Patch
Comment 2 zalan 2021-05-23 07:06:27 PDT 
Created attachment 429461 [details]
Patch
Comment 3 Antti Koivisto 2021-05-24 10:08:29 PDT 
Comment on attachment 429461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429461&action=review

> Source/WebCore/layout/formattingContexts/block/BlockFormattingContext.h:59
> +    const FormattingGeometry& formattingGeometry() const final { return m_blockFormattingGeometry; }
> +    const FormattingQuirks& formattingQuirks() const final { return m_blockFormattingQuirks; }

I think you could just return BlockFormattingFoo& here and remove the specialised versions. You can override with more narrow type.
Comment 4 zalan 2021-05-24 12:59:16 PDT 
Created attachment 429555 [details]
Patch
Comment 5 EWS 2021-05-24 15:30:17 PDT 
Committed r277972 (238094@main): <https://commits.webkit.org/238094@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429555 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-24 15:31:24 PDT 
<rdar://problem/78422093>