Bug 226145 - Drop WTF::tryHoldLock() as it is incompatible with Clang Thread Safety Analysis
Summary: Drop WTF::tryHoldLock() as it is incompatible with Clang Thread Safety Analysis
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://clang.llvm.org/docs/ThreadSaf...
Keywords: InRadar
Depends on:
Blocks: 226157
  Show dependency tree / graph
 
Reported: 2021-05-22 14:56 PDT by Chris Dumez
Modified: 2021-05-23 12:56 PDT (History)
37 users (show)

See Also:

Attachments
Patch (56.77 KB, patch)
2021-05-22 15:37 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.98 KB, patch)
2021-05-22 15:49 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.77 KB, patch)
2021-05-22 16:00 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.78 KB, patch)
2021-05-22 16:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (57.67 KB, patch)
2021-05-22 16:23 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.82 KB, patch)
2021-05-22 16:32 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.78 KB, patch)
2021-05-22 16:43 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (57.04 KB, patch)
2021-05-22 16:47 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (56.81 KB, patch)
2021-05-22 18:08 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (25.77 KB, patch)
2021-05-22 18:51 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (26.00 KB, patch)
2021-05-22 19:01 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (35.15 KB, patch)
2021-05-22 19:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (34.80 KB, patch)
2021-05-22 19:20 PDT, Chris Dumez 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (12) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-22 14:56:12 PDT 
Drop WTF::tryHoldLock() as it is incompatible with Clang Thread Safety Analysis. Instead, use the following pattern:
```
Locker locker { DeferLock, m_lock };
if (locker.tryLock())
```
Comment 1 Chris Dumez 2021-05-22 15:37:40 PDT 
Created attachment 429429 [details]
Patch
Comment 2 EWS Watchlist 2021-05-22 15:38:23 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2021-05-22 15:49:43 PDT 
Created attachment 429430 [details]
Patch
Comment 4 Chris Dumez 2021-05-22 16:00:36 PDT 
Created attachment 429432 [details]
Patch
Comment 5 Chris Dumez 2021-05-22 16:16:59 PDT 
Created attachment 429433 [details]
Patch
Comment 6 Chris Dumez 2021-05-22 16:23:56 PDT 
Created attachment 429436 [details]
Patch
Comment 7 Chris Dumez 2021-05-22 16:32:35 PDT 
Created attachment 429437 [details]
Patch
Comment 8 Chris Dumez 2021-05-22 16:43:13 PDT 
Created attachment 429439 [details]
Patch
Comment 9 Chris Dumez 2021-05-22 16:47:56 PDT 
Created attachment 429440 [details]
Patch
Comment 10 Chris Dumez 2021-05-22 16:59:45 PDT 
Not sure what's going on, it builds fine locally :/
Comment 11 Chris Dumez 2021-05-22 18:08:53 PDT 
Created attachment 429443 [details]
Patch
Comment 12 Chris Dumez 2021-05-22 18:51:29 PDT 
Created attachment 429446 [details]
Patch
Comment 13 Chris Dumez 2021-05-22 19:01:06 PDT 
Created attachment 429447 [details]
Patch
Comment 14 Chris Dumez 2021-05-22 19:18:59 PDT 
Created attachment 429448 [details]
Patch
Comment 15 Chris Dumez 2021-05-22 19:20:29 PDT 
Created attachment 429449 [details]
Patch
Comment 16 Darin Adler 2021-05-23 12:44:36 PDT 
Comment on attachment 429449 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429449&action=review

> Source/WTF/wtf/Locker.h:59
> +constexpr AdoptLockTag AdoptLock = AdoptLockTag();

I am surprised that we need the "= AdoptLockTag()" here. Can we omit it?
Comment 17 Chris Dumez 2021-05-23 12:53:14 PDT 
(In reply to Darin Adler from comment #16)
> Comment on attachment 429449 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429449&action=review
> 
> > Source/WTF/wtf/Locker.h:59
> > +constexpr AdoptLockTag AdoptLock = AdoptLockTag();
> 
> I am surprised that we need the "= AdoptLockTag()" here. Can we omit it?

Will check and land without it if it builds. I had copied the definition from <mutex>:
/* _LIBCPP_INLINE_VAR */ constexpr adopt_lock_t  adopt_lock  = adopt_lock_t();
Comment 18 Chris Dumez 2021-05-23 12:55:44 PDT 
Committed r277932 (238062@main): <https://commits.webkit.org/238062@main>
Comment 19 Radar WebKit Bug Importer 2021-05-23 12:56:30 PDT 
<rdar://problem/78371802>
Comment 20 Chris Dumez 2021-05-23 12:56:37 PDT 
(In reply to Chris Dumez from comment #17)
> (In reply to Darin Adler from comment #16)
> > Comment on attachment 429449 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=429449&action=review
> > 
> > > Source/WTF/wtf/Locker.h:59
> > > +constexpr AdoptLockTag AdoptLock = AdoptLockTag();
> > 
> > I am surprised that we need the "= AdoptLockTag()" here. Can we omit it?
> 
> Will check and land without it if it builds. I had copied the definition
> from <mutex>:
> /* _LIBCPP_INLINE_VAR */ constexpr adopt_lock_t  adopt_lock  =
> adopt_lock_t();

Yes, it built fine without it.