Bug 226137 - Remove StringBuilder::appendLiteral
Summary: Remove StringBuilder::appendLiteral
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 23:07 PDT by Darin Adler
Modified: 2021-05-24 14:53 PDT (History)
59 users (show)

See Also:

Attachments
Patch (312.26 KB, patch)
2021-05-22 00:57 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (346.33 KB, patch)
2021-05-22 12:21 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (349.52 KB, patch)
2021-05-23 15:48 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (349.83 KB, patch)
2021-05-23 22:06 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-05-21 23:07:53 PDT 
Remove StringBuilder::appendLiteral
Comment 1 Darin Adler 2021-05-22 00:57:08 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2021-05-22 12:21:26 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2021-05-22 12:22:24 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 4 Darin Adler 2021-05-23 15:48:37 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2021-05-23 22:06:22 PDT 
Created attachment 429501 [details]
Patch
Comment 6 Chris Dumez 2021-05-24 08:33:58 PDT 
Comment on attachment 429501 [details]
Patch

r=me
Comment 7 Sam Weinig 2021-05-24 09:17:34 PDT 
Nice!
Comment 8 EWS 2021-05-24 14:51:57 PDT 
Committed r277967 (238091@main): <https://commits.webkit.org/238091@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429501 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-24 14:53:23 PDT 
<rdar://problem/78420303>