RESOLVED FIXED 226137
Remove StringBuilder::appendLiteral 
https://bugs.webkit.org/show_bug.cgi?id=226137
Summary Remove StringBuilder::appendLiteral
Darin Adler
Reported 2021-05-21 23:07:53 PDT
Remove StringBuilder::appendLiteral
Attachments
Patch (312.26 KB, patch)
2021-05-22 00:57 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (346.33 KB, patch)
2021-05-22 12:21 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (349.52 KB, patch)
2021-05-23 15:48 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (349.83 KB, patch)
2021-05-23 22:06 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2021-05-22 00:57:08 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2021-05-22 12:21:26 PDT Comment hidden (obsolete)
EWS Watchlist
Comment 3 2021-05-22 12:22:24 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Darin Adler
Comment 4 2021-05-23 15:48:37 PDT Comment hidden (obsolete)
Darin Adler
Comment 5 2021-05-23 22:06:22 PDT
Created attachment 429501 [details] Patch
Chris Dumez
Comment 6 2021-05-24 08:33:58 PDT
Comment on attachment 429501 [details] Patch r=me
Sam Weinig
Comment 7 2021-05-24 09:17:34 PDT
Nice!
EWS
Comment 8 2021-05-24 14:51:57 PDT
Committed r277967 (238091@main): <https://commits.webkit.org/238091@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 429501 [details].
Radar WebKit Bug Importer
Comment 9 2021-05-24 14:53:23 PDT
<rdar://problem/78420303>
Note You need to log in before you can comment on or make changes to this bug.