Remove WTF::holdLock() / WTF::holdLockIf() because they are not compatible with Clang Thread Safety Analysis. All call sites have been converted to use the Locker constructor directly.
Created attachment 429401 [details]
Committed r277914 (238047@main): <https://commits.webkit.org/238047@main>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 429401 [details].
Out of curiosity, why is it incompatible? You'd think and r-value reference would be the same as as the r-value constructor?
(In reply to Keith Miller from comment #4)
> Out of curiosity, why is it incompatible? You'd think and r-value reference
> would be the same as as the r-value constructor?
Not sure which r-value constructor you're referring to. The Locker<CheckedLock> specialization in CheckedLock.h does not have a move or copy constructor. AFAIK, this isn't supposed by clang thread safety analysis (https://clang.llvm.org/docs/ThreadSafetyAnalysis.html).