RESOLVED FIXED 226133
Replace LockHolder with Locker in local variables 
https://bugs.webkit.org/show_bug.cgi?id=226133
Summary Replace LockHolder with Locker in local variables
Chris Dumez
Reported 2021-05-21 20:04:43 PDT
Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker<T>.
Attachments
Patch (276.14 KB, patch)
2021-05-21 20:12 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (276.17 KB, patch)
2021-05-21 20:20 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (276.78 KB, patch)
2021-05-21 21:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (277.93 KB, patch)
2021-05-21 21:38 PDT, Chris Dumez 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (277.59 KB, patch)
2021-05-22 08:30 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-05-21 20:12:26 PDT
Created attachment 429393 [details] Patch
EWS Watchlist
Comment 2 2021-05-21 20:13:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Chris Dumez
Comment 3 2021-05-21 20:20:14 PDT
Created attachment 429396 [details] Patch
Chris Dumez
Comment 4 2021-05-21 21:16:50 PDT
Created attachment 429397 [details] Patch
Chris Dumez
Comment 5 2021-05-21 21:38:11 PDT
Created attachment 429398 [details] Patch
Chris Dumez
Comment 6 2021-05-21 22:49:29 PDT
Comment on attachment 429398 [details] Patch Clearing flags on attachment: 429398 Committed r277913 (238046@main): <https://commits.webkit.org/238046@main>
Chris Dumez
Comment 7 2021-05-21 22:49:34 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2021-05-21 22:50:18 PDT
<rdar://problem/78343441>
WebKit Commit Bot
Comment 9 2021-05-22 04:13:40 PDT
Re-opened since this is blocked by bug 226140
Chris Dumez
Comment 11 2021-05-22 08:30:15 PDT
Created attachment 429412 [details] Patch
Chris Dumez
Comment 12 2021-05-22 09:49:54 PDT
Comment on attachment 429412 [details] Patch Clearing flags on attachment: 429412 Committed r277920 (238053@main): <https://commits.webkit.org/238053@main>
Chris Dumez
Comment 13 2021-05-22 09:49:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.