Bug 226133 - Replace LockHolder with Locker in local variables
Summary: Replace LockHolder with Locker in local variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://en.cppreference.com/w/cpp/lan...
Keywords: InRadar
Depends on: 226140
Blocks: 226138
  Show dependency treegraph
 
Reported: 2021-05-21 20:04 PDT by Chris Dumez
Modified: 2021-05-22 09:49 PDT (History)
49 users (show)

See Also:


Attachments
Patch (276.14 KB, patch)
2021-05-21 20:12 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (276.17 KB, patch)
2021-05-21 20:20 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (276.78 KB, patch)
2021-05-21 21:16 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (277.93 KB, patch)
2021-05-21 21:38 PDT, Chris Dumez
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (277.59 KB, patch)
2021-05-22 08:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-21 20:04:43 PDT
Replace LockHolder with Locker in local variables. It is shorter and it allows switching the lock type more easily since the compiler with deduce the lock type T for Locker<T>.
Comment 1 Chris Dumez 2021-05-21 20:12:26 PDT
Created attachment 429393 [details]
Patch
Comment 2 EWS Watchlist 2021-05-21 20:13:27 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Chris Dumez 2021-05-21 20:20:14 PDT
Created attachment 429396 [details]
Patch
Comment 4 Chris Dumez 2021-05-21 21:16:50 PDT
Created attachment 429397 [details]
Patch
Comment 5 Chris Dumez 2021-05-21 21:38:11 PDT
Created attachment 429398 [details]
Patch
Comment 6 Chris Dumez 2021-05-21 22:49:29 PDT
Comment on attachment 429398 [details]
Patch

Clearing flags on attachment: 429398

Committed r277913 (238046@main): <https://commits.webkit.org/238046@main>
Comment 7 Chris Dumez 2021-05-21 22:49:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2021-05-21 22:50:18 PDT
<rdar://problem/78343441>
Comment 9 WebKit Commit Bot 2021-05-22 04:13:40 PDT
Re-opened since this is blocked by bug 226140
Comment 11 Chris Dumez 2021-05-22 08:30:15 PDT
Created attachment 429412 [details]
Patch
Comment 12 Chris Dumez 2021-05-22 09:49:54 PDT
Comment on attachment 429412 [details]
Patch

Clearing flags on attachment: 429412

Committed r277920 (238053@main): <https://commits.webkit.org/238053@main>
Comment 13 Chris Dumez 2021-05-22 09:49:59 PDT
All reviewed patches have been landed.  Closing bug.