Bug 226129 - Fix locking issue for AudioDestinationCocoa::m_isPlaying
Summary: Fix locking issue for AudioDestinationCocoa::m_isPlaying
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 18:14 PDT by Chris Dumez
Modified: 2021-05-21 21:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch (2.89 KB, patch)
2021-05-21 18:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (2.89 KB, patch)
2021-05-21 20:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-21 18:14:32 PDT 
Fix locking issue for AudioDestinationCocoa::m_isPlaying. The AudioDestinationCocoa::isPlaying() getter fails to lock. isPlaying() may get called from the main thread and the audio rendering thread.
Comment 1 Chris Dumez 2021-05-21 18:18:29 PDT 
Created attachment 429381 [details]
Patch
Comment 2 Chris Dumez 2021-05-21 20:14:10 PDT 
Created attachment 429394 [details]
Patch
Comment 3 EWS 2021-05-21 21:24:32 PDT 
Committed r277910 (238043@main): <https://commits.webkit.org/238043@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429394 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-21 21:25:20 PDT 
<rdar://problem/78342090>