Bug 226128 - [Cocoa] Hang in WebM format reader when loading content from https://powerrangers.fandom.com/
Summary: [Cocoa] Hang in WebM format reader when loading content from https://powerran...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 17:04 PDT by Jer Noble
Modified: 2021-05-28 13:13 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.07 KB, patch)
2021-05-21 17:09 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (3.10 KB, patch)
2021-05-21 17:18 PDT, Jer Noble 		jer.noble: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (5.03 KB, patch)
2021-05-28 09:38 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-05-21 17:04:59 PDT 
[Cocoa] Hang in WebM format reader when loading content from https://powerrangers.fandom.com/
Comment 1 Jer Noble 2021-05-21 17:05:31 PDT 
<rdar://77645877>
Comment 2 Jer Noble 2021-05-21 17:09:07 PDT 
Created attachment 429371 [details]
Patch
Comment 3 Jer Noble 2021-05-21 17:18:54 PDT 
Created attachment 429375 [details]
Patch for landing
Comment 4 Kimmo Kinnunen 2021-05-25 04:53:33 PDT 
Immediately after the lines that query these properties are queries for other properties. The hangs cannot most likely be solved like this.

Bug 226217 should contain the general purpose test case to solve.
Comment 5 Jer Noble 2021-05-27 15:08:56 PDT 
(In reply to Kimmo Kinnunen from comment #4)
> Immediately after the lines that query these properties are queries for
> other properties. The hangs cannot most likely be solved like this.

The only property we support querying for is `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of what property they query for, unless it's Duration, we won't block.
Comment 6 Kimmo Kinnunen 2021-05-27 23:00:10 PDT 
(In reply to Jer Noble from comment #5)
> The only property we support querying for is
> `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of
> what property they query for, unless it's Duration, we won't block.

I mean: track array blocks, stuff inside tracks block...
Comment 7 Jer Noble 2021-05-28 09:38:08 PDT 
Created attachment 430020 [details]
Patch for landing
Comment 8 Jer Noble 2021-05-28 09:39:26 PDT 
(In reply to Kimmo Kinnunen from comment #6)
> (In reply to Jer Noble from comment #5)
> > The only property we support querying for is
> > `kMTPluginFormatReaderProperty_Duration`, so with this patch, regardless of
> > what property they query for, unless it's Duration, we won't block.
> 
> I mean: track array blocks, stuff inside tracks block...

Right, we have to systematically remove sources of deadlocks; this is just one of them.
Comment 9 EWS 2021-05-28 13:13:43 PDT 
Committed r278223 (238261@main): <https://commits.webkit.org/238261@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430020 [details].