Bug 226120 - All Netflix playback fails after r277740
Summary: All Netflix playback fails after r277740
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 16:16 PDT by Eric Carlson
Modified: 2021-05-21 19:07 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.43 KB, patch)
2021-05-21 18:35 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-05-21 16:16:04 PDT 
All Netflix playback fails with error S7399-1260 after r277740
Comment 1 Radar WebKit Bug Importer 2021-05-21 16:19:19 PDT 
<rdar://problem/78333782>
Comment 2 Sam Weinig 2021-05-21 18:04:55 PDT 
I think I spotted the issue. Missing ! in CDMInstanceFairPlayStreamingAVFObjC.mm:

             auto keyIDVector = base64Decode(keyIDString);
-            if (keyIDVector)
+            if (!keyIDVector)
                 return false;

Testing a fix now.
Comment 3 Sam Weinig 2021-05-21 18:35:34 PDT 
Created attachment 429382 [details]
Patch
Comment 4 Sam Weinig 2021-05-21 18:36:06 PDT 
Is there anyway to test this code path currently?
Comment 5 EWS 2021-05-21 19:07:24 PDT 
Committed r277905 (238038@main): <https://commits.webkit.org/238038@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429382 [details].