Bug 226115 – [test-lldb-webkit] Update for Xcode 12.5

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Jonathan Bedard]

We need to make some changes to test-lldb-webkit to support Xcode 12.5 (and Python 3)

[Radar WebKit Bug Importer]

<rdar://problem/78331664>

[Jonathan Bedard]

Created attachment 429351 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 429351 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429351&action=review

> Tools/ChangeLog:3
> +        [test-lldb-webkit] Update for Xcode 12.5

Does this script continue to work on older OS versions?

> Tools/lldb/dump_class_layout_unittest.py:321
> -  +2 <  2>   <PADDING: 2 bytes>
> +  +2 <  1>   <PADDING: 1 bytes>

This looks like a compiler change, not an lldb change. At the very least, we need comments updated in the .cpp counterpart, but really we need to understand what changed.

[Jonathan Bedard]

(In reply to Alexey Proskuryakov from comment #3)
> Comment on attachment 429351 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429351&action=review
> 
> > Tools/ChangeLog:3
> > +        [test-lldb-webkit] Update for Xcode 12.5
> 
> Does this script continue to work on older OS versions?
> 
> > Tools/lldb/dump_class_layout_unittest.py:321
> > -  +2 <  2>   <PADDING: 2 bytes>
> > +  +2 <  1>   <PADDING: 1 bytes>
> 
> This looks like a compiler change, not an lldb change. At the very least, we
> need comments updated in the .cpp counterpart, but really we need to
> understand what changed.

The encoding bits should work fine, but the class layout will almost certainly fail with different compiler versions, yes.

[Jonathan Bedard]

Created attachment 429706 [details]
Patch

[EWS]

Committed r278083 (238162@main): <https://commits.webkit.org/238162@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429706 [details].