Bug 226112 - Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Summary: Make CGColorSpaceRef argument coding match other CF objects and use CGColorSp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 14:14 PDT by Sam Weinig
Modified: 2021-05-21 19:24 PDT (History)
4 users (show)

See Also:

Attachments
Patch (55.59 KB, patch)
2021-05-21 14:19 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (55.54 KB, patch)
2021-05-21 14:21 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (56.19 KB, patch)
2021-05-21 17:18 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (56.16 KB, patch)
2021-05-21 18:04 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-21 14:14:30 PDT 
Make CGColorSpaceRef argument coding match other CF objects and use CGColorSpaceCreateWithPropertyList for fallback
Comment 1 Sam Weinig 2021-05-21 14:19:43 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-05-21 14:21:54 PDT 
Created attachment 429341 [details]
Patch
Comment 3 Darin Adler 2021-05-21 15:51:05 PDT 
Comment on attachment 429341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429341&action=review

> Source/WebKit/Shared/cf/ArgumentCodersCF.cpp:700
> +    auto propertyList = adoptCF(CGColorSpaceCopyPropertyList(colorSpace));
> +    encoder << CGColorSpaceEncodingScheme::PropertyList;
> +    encoder << propertyList;

No need for this local variable. Maybe we can write this?

    encoder << CGColorSpaceEncodingScheme::PropertyList << adoptCF(CGColorSpaceCopyPropertyList(colorSpace));
Comment 4 Sam Weinig 2021-05-21 17:18:47 PDT 
Created attachment 429374 [details]
Patch
Comment 5 Sam Weinig 2021-05-21 18:04:12 PDT 
Created attachment 429379 [details]
Patch
Comment 6 EWS 2021-05-21 19:23:50 PDT 
Committed r277906 (238039@main): <https://commits.webkit.org/238039@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429379 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-21 19:24:19 PDT 
<rdar://problem/78339484>