Bug 226106 - [Cocoa] Expand IOKit method filters to cover items encountered during testing
Summary: [Cocoa] Expand IOKit method filters to cover items encountered during testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 13:27 PDT by Brent Fulgham
Modified: 2021-05-21 15:33 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2021-05-21 14:06 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch for landing (2.19 KB, patch)
2021-05-21 15:05 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-05-21 13:27:51 PDT
As we gather more telemetry from systems running with IOKit method filters, we have identified additional methods that are needed for normal use cases.

Per our plan, we will unblock those cases and consider further hardening in an follow-up patch once have worked with framework teams to reduce these needs.
Comment 1 Radar WebKit Bug Importer 2021-05-21 14:04:59 PDT
<rdar://problem/78327511>
Comment 2 Brent Fulgham 2021-05-21 14:06:20 PDT
Created attachment 429337 [details]
Patch
Comment 3 Per Arne Vollan 2021-05-21 14:23:58 PDT
Comment on attachment 429337 [details]
Patch

Great! R=me.
Comment 4 Per Arne Vollan 2021-05-21 14:53:27 PDT
Comment on attachment 429337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:294
> +                        39
> +                        40

Should these be under IOSurfaceRootUserClient instead?
Comment 5 Per Arne Vollan 2021-05-21 14:55:11 PDT
Comment on attachment 429337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:447
> +                    38

Is 42 also needed here?
Comment 6 Brent Fulgham 2021-05-21 15:04:50 PDT
Comment on attachment 429337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429337&action=review

>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:294
>> +                        40
> 
> Should these be under IOSurfaceRootUserClient instead?

No -- these were shown in telemetry to be used by AGXDeviceUserClient, but not by IOSurfaceRootUserClient.

>> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:447
>> +                    38
> 
> Is 42 also needed here?

No -- but it is needed for AGXDeviceUserClient, whoops! I'll fix that before landing.
Comment 7 Brent Fulgham 2021-05-21 15:05:25 PDT
Created attachment 429348 [details]
Patch for landing
Comment 8 EWS 2021-05-21 15:33:29 PDT
Committed r277894 (238030@main): <https://commits.webkit.org/238030@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429348 [details].