Bug 226104 - REGRESSION(r276993): 5 TestWebKitAPI.AudioRoutingArbitration (api-tests) are constant failures
Summary: REGRESSION(r276993): 5 TestWebKitAPI.AudioRoutingArbitration (api-tests) are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 13:00 PDT by Jer Noble
Modified: 2021-06-08 16:19 PDT (History)
11 users (show)

See Also:

Attachments
Patch (19.86 KB, patch)
2021-05-21 13:11 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.04 KB, patch)
2021-05-21 13:46 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (19.34 KB, patch)
2021-05-21 14:00 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (22.62 KB, patch)
2021-05-21 15:54 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (25.33 KB, patch)
2021-05-21 17:15 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (19.92 KB, patch)
2021-06-02 09:01 PDT, Jer Noble 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (19.94 KB, patch)
2021-06-02 10:35 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-05-21 13:00:57 PDT 
REGRESSION(r276993): 5 TestWebKitAPI.AudioRoutingArbitration (api-tests) are constant failures
Comment 1 Jer Noble 2021-05-21 13:01:15 PDT 
<rdar://77998049>
Comment 2 Jer Noble 2021-05-21 13:11:47 PDT 
Created attachment 429330 [details]
Patch
Comment 3 Jer Noble 2021-05-21 13:46:20 PDT 
Created attachment 429334 [details]
Patch
Comment 4 Jer Noble 2021-05-21 14:00:29 PDT 
Created attachment 429336 [details]
Patch
Comment 5 Jer Noble 2021-05-21 15:54:40 PDT 
Created attachment 429355 [details]
Patch
Comment 6 Jer Noble 2021-05-21 17:15:49 PDT 
Created attachment 429373 [details]
Patch for landing
Comment 7 Eric Carlson 2021-05-21 17:29:17 PDT 
Comment on attachment 429355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429355&action=review

> Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:291
> +    bool currentDataAvailable() const { return m_readyState >= MediaPlayer::ReadyState::HaveCurrentData; }

You probably didn't mean to include this :-)
Comment 8 Jer Noble 2021-06-02 09:01:33 PDT 
Created attachment 430366 [details]
Patch for landing
Comment 9 Jer Noble 2021-06-02 10:35:30 PDT 
Created attachment 430374 [details]
Patch for landing
Comment 10 EWS 2021-06-02 14:36:00 PDT 
Committed r278374 (238401@main): <https://commits.webkit.org/238401@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 430374 [details].