Bug 22610 - We should plant shift right immediate instructions,
Summary: We should plant shift right immediate instructions,
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 16:46 PST by Gavin Barraclough
Modified: 2008-12-02 18:21 PST (History)
0 users

See Also:


Attachments
The patch (2.77 KB, patch)
2008-12-02 16:47 PST, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2008-12-02 16:46:40 PST
when JIT generating for op_rshift, and the second operand is an immediate.
Comment 1 Gavin Barraclough 2008-12-02 16:47:42 PST
Created attachment 25690 [details]
The patch
Comment 2 Geoffrey Garen 2008-12-02 16:57:07 PST
Comment on attachment 25690 [details]
The patch

> +                __ sarl_i8r(JSImmediate::getTruncatedUInt32(value) & 0x1f, X86::eax);

Let's put a comment here, like, "Prohibit shifting by more than 31."

r=me
Comment 3 Gavin Barraclough 2008-12-02 18:21:12 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/jit/JIT.cpp
Transmitting file data ..
Committed revision 38928.