RESOLVED FIXED 22610
We should plant shift right immediate instructions, 
https://bugs.webkit.org/show_bug.cgi?id=22610
Summary We should plant shift right immediate instructions,
Gavin Barraclough
Reported 2008-12-02 16:46:40 PST
when JIT generating for op_rshift, and the second operand is an immediate.
Attachments
The patch (2.77 KB, patch)
2008-12-02 16:47 PST, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2008-12-02 16:47:42 PST
Created attachment 25690 [details] The patch
Geoffrey Garen
Comment 2 2008-12-02 16:57:07 PST
Comment on attachment 25690 [details] The patch > + __ sarl_i8r(JSImmediate::getTruncatedUInt32(value) & 0x1f, X86::eax); Let's put a comment here, like, "Prohibit shifting by more than 31." r=me
Gavin Barraclough
Comment 3 2008-12-02 18:21:12 PST
Sending JavaScriptCore/ChangeLog Sending JavaScriptCore/jit/JIT.cpp Transmitting file data .. Committed revision 38928.
Note You need to log in before you can comment on or make changes to this bug.