Bug 226077 – Add MediaSession.callActionHandler

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jean-Yves Avenard [:jya]]

Add MediaSession.callActionHandler

[Jean-Yves Avenard [:jya]]

rdar://77463304

[Jean-Yves Avenard [:jya]]

Created attachment 429283 [details]
Patch

[Peng Liu]

Comment on attachment 429283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429283&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:288
> +bool MediaSession::callActionHandler(const MediaSessionActionDetails& actionDetails, TriggerGestureIndicator triggerGestureIndicator )

Nit. An extra space.

> Source/WebCore/Modules/mediasession/MediaSession.h:94
> +        Yes,

Normally we define `No` as the first value in an enum class.

[Chris Dumez]

Comment on attachment 429283 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429283&action=review

> Source/WebCore/Modules/mediasession/MediaSession.cpp:291
> +        Optional<UserGestureIndicator> maybeGestureIndicator;

The existing pattern in WebKit seems to be:
UserGestureIndicator gestureIndicator(triggerGestureIndicator == TriggerGestureIndicator::Yes ? makeOptional(ProcessingUserGesture) : WTF::nullopt);

>> Source/WebCore/Modules/mediasession/MediaSession.h:94
>> +        Yes,
> 
> Normally we define `No` as the first value in an enum class.

+1 (so that No = 0, Yes = 1)

[Jean-Yves Avenard [:jya]]

Created attachment 429877 [details]
Patch

Apply comments

[Eric Carlson]

Comment on attachment 429877 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429877&action=review

> Source/WebCore/ChangeLog:6
> +

It would be good to have a description of why we are making this change.

[Jean-Yves Avenard [:jya]]

Created attachment 429985 [details]
Patch

[EWS]

Committed r278222 (238260@main): <https://commits.webkit.org/238260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429985 [details].