Bug 226073 - Compile error when ANGLE is used on Linux
Summary: Compile error when ANGLE is used on Linux
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-21 03:17 PDT by Eleni Maria Stea
Modified: 2021-05-21 07:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2021-05-21 03:27 PDT, Eleni Maria Stea
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eleni Maria Stea 2021-05-21 03:17:17 PDT
In platform/graphics/nicosia/texmap/NicosiaGCGLLayer.cpp:
Function paintRenderingResultsToCanvas expects a reference, but a pointer is passed instead causing compile errors when ANGLE is used.
Comment 1 Eleni Maria Stea 2021-05-21 03:27:24 PDT
Created attachment 429279 [details]
Patch
Comment 2 EWS 2021-05-21 07:54:42 PDT
Committed r277861 (238003@main): <https://commits.webkit.org/238003@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429279 [details].
Comment 3 Radar WebKit Bug Importer 2021-05-21 07:55:17 PDT
<rdar://problem/78310259>
Comment 4 Michael Catanzaro 2021-05-21 07:58:18 PDT
Comment on attachment 429279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429279&action=review

> Source/WebCore/ChangeLog:4
> +        Function paintRenderingResultsToCanvas expects a reference, not a
> +        pointer. Fixed the compile error.

In the future: the first line of the changelog is normally the bug title. You can write your commit message underneath the reviewed by line, below.