Bug 226069 – [Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Cocoa] Last few seconds of 'audio/webm; codecs=vorbis' appended to a SampleBuffer are not played

[Jer Noble]

<rdar://78004793>

[Jer Noble]

Created attachment 429267 [details]
Patch

[Jer Noble]

mac-AS-debug-wk2 bot is failing because it's not been updated to macOS 11.3, which has support for Vorbis.

[EWS]

Committed r277867 (238007@main): <https://commits.webkit.org/238007@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429267 [details].

[Truitt Savell]

the new test platform/mac-bigsur/media/media-source/media-vorbis-partial.html

is failing constantly sense introduction

History:
https://results.webkit.org/?suite=layout-tests&test=platform%2Fmac-bigsur%2Fmedia%2Fmedia-source%2Fmedia-vorbis-partial.html

Diff:
--- /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/platform/mac-bigsur/media/media-source/media-vorbis-partial-expected.txt
+++ /Volumes/Data/worker/bigsur-release-tests-wk2/build/layout-test-results/platform/mac-bigsur/media/media-source/media-vorbis-partial-actual.txt
@@ -3,10 +3,9 @@
 EVENT(sourceopen)
 RUN(source.duration = loader.duration())
 RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+NotSupportedError: The operation is not supported.
 RUN(sourceBuffer.appendBuffer(loader.initSegment()))
-EVENT(update)
-Append a media segment.
-RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
-EVENT(update)
-EXPECTED (sourceBuffer.buffered.end(0) == source.duration == 'true') OK
+TypeError: undefined is not an object (evaluating 'sourceBuffer.appendBuffer')
+Caught exception: "TypeError: undefined is not an object (evaluating 'element.addEventListener')" FAIL
 END OF TEST
+

[WebKit Commit Bot]

Re-opened since this is blocked by bug 226211

[Jer Noble]

<rdar://78795924>

[Jer Noble]

Created attachment 432134 [details]
Patch for landing

[Jer Noble]

Created attachment 432135 [details]
Patch for landing

[Jer Noble]

Created attachment 432175 [details]
Patch for landing

[Jer Noble]

Created attachment 432206 [details]
Patch for landing

[EWS]

Committed r279250 (239134@main): <https://commits.webkit.org/239134@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432206 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 227499

[Jean-Yves Avenard [:jya]]

*** Bug 227382 has been marked as a duplicate of this bug. ***

[Jean-Yves Avenard [:jya]]

Created attachment 432607 [details]
Patch

[Eric Carlson]

Comment on attachment 432607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432607&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:304
> +            if (numActuallyRead)

We return early above if `numActuallyRead` is null

[Jean-Yves Avenard [:jya]]

Created attachment 432641 [details]
Patch

skip opus test on non Montarey OS as the codec isn't supported

[Jean-Yves Avenard [:jya]]

Created attachment 432651 [details]
Patch

apply comment

[Jean-Yves Avenard [:jya]]

Created attachment 432665 [details]
Patch

Move tests to media/media-source rather than platform

[Jean-Yves Avenard [:jya]]

Created attachment 432666 [details]
Patch

TestExpectations file wasn't committed

[Eric Carlson]

Comment on attachment 432666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432666&action=review

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:304
> +                *numActuallyRead += lastRead;

Nit: indentation is wrong

[Jean-Yves Avenard [:jya]]

Created attachment 432736 [details]
Patch

apply comment

[EWS]

Committed r279492 (239344@main): <https://commits.webkit.org/239344@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 432736 [details].

[Jean-Yves Avenard [:jya]]

iOS-wk2 isn't related to this patch, it doesn't use MSE nor a webm container.