Bug 226068 - Putting HashMap in a heap block hurts memory use, speed, code size
Summary: Putting HashMap in a heap block hurts memory use, speed, code size
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
: 225984 (view as bug list)
Depends on: 226162
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-20 23:10 PDT by Darin Adler
Modified: 2021-05-23 23:10 PDT (History)
40 users (show)

See Also:

Attachments
Patch (275.27 KB, patch)
2021-05-21 12:51 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (281.80 KB, patch)
2021-05-21 22:14 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-05-20 23:10:43 PDT 
Putting HashMap in a heap block hurts memory use, speed, code size
Comment 1 Darin Adler 2021-05-21 12:51:13 PDT Comment hidden (obsolete)
Comment 2 Radar WebKit Bug Importer 2021-05-21 12:52:17 PDT 
<rdar://problem/78323737>
Comment 3 Darin Adler 2021-05-21 16:22:32 PDT 
*** Bug 225984 has been marked as a duplicate of this bug. ***
Comment 4 Darin Adler 2021-05-21 22:14:03 PDT Comment hidden (obsolete)
Comment 5 Darin Adler 2021-05-21 22:15:58 PDT 
It’s possible that none of the memory savings here are enough to make a noticeable difference, but also possible that one of these might be common enough that we hit the jackpot. Might be less memory use or heap fragmentation.
Comment 6 Darin Adler 2021-05-23 22:24:46 PDT 
After studying test failures, I found one case that will be hard to do. I think I will make a first patch that does most of these in a separate bug and then come back to this bug later to finish the job.