Bug 226063 - [LFC][TFC][Quirks] Use box-sizing: border-box when computing cell height
Summary: [LFC][TFC][Quirks] Use box-sizing: border-box when computing cell height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 19:05 PDT by zalan
Modified: 2021-05-21 06:12 PDT (History)
4 users (show)

See Also:


Attachments
Patch (8.82 KB, patch)
2021-05-20 19:31 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (8.82 KB, patch)
2021-05-20 20:46 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2021-05-20 19:05:12 PDT
ssia
Comment 1 zalan 2021-05-20 19:31:14 PDT
Created attachment 429257 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-05-20 20:00:52 PDT
Comment on attachment 429257 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429257&action=review

> Source/WebCore/layout/formattingContexts/table/TableFormattingContext.cpp:307
> +        auto heightIsBorderBox = layoutState().inQuirksMode() || cellBox.style().boxSizing() == BoxSizing::BorderBox;

heightUsesBorderBox?
Comment 3 zalan 2021-05-20 20:46:37 PDT
Created attachment 429263 [details]
Patch
Comment 4 EWS 2021-05-21 06:11:17 PDT
Committed r277856 (237998@main): <https://commits.webkit.org/237998@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429263 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-21 06:12:17 PDT
<rdar://problem/78307491>