Bug 226049 - sampleColor in PageColorSampler is getting more data than it needs
Summary: sampleColor in PageColorSampler is getting more data than it needs
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 16:04 PDT by Sam Weinig
Modified: 2021-05-27 16:05 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-20 16:04:33 PDT 
Not sure if it happened when I switched it to getPixelBuffer, but sampleColor in PageColorSampler is getting more data than it needs since each snapshot is now returning 16 bytes (a 2x2 of pixels) rather than the 4 bytes it wants.
Comment 1 Sam Weinig 2021-05-20 16:12:52 PDT 
It's been there all along it seems. And the real issue is that snapshot ImageBuffer is being created at deviceScaleFactor. Probably need to add another option to snapshot at 1x.
Comment 2 Radar WebKit Bug Importer 2021-05-27 16:05:16 PDT 
<rdar://problem/78592414>