Bug 226048 – [iOS][FCR] <select> options are unnecessarily truncated

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/76008154>

[Aditya Keerthi]

Created attachment 429234 [details]
Patch

[Tim Horton]

Comment on attachment 429234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429234&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477
> +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)

I think you want a WK prefix here? Or maybe it's OK and the compiler won't whine if it has the real one because it's a #define?

Also, does UIKit ignore the random flag bit if it /doesn't/ have this change?

[Aditya Keerthi]

(In reply to Tim Horton from comment #3)
> Comment on attachment 429234 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429234&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477
> > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)
> 
> I think you want a WK prefix here? Or maybe it's OK and the compiler won't
> whine if it has the real one because it's a #define?

Yeah, it's fine because it's a #define. (Wenson suggested this approach)

> Also, does UIKit ignore the random flag bit if it /doesn't/ have this change?

It's ignored. I verified the change has no effect if the corresponding UIKit change is not present.

[EWS]

Committed r277846 (237988@main): <https://commits.webkit.org/237988@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429234 [details].