Bug 226048 - [iOS][FCR] <select> options are unnecessarily truncated
Summary: [iOS][FCR] <select> options are unnecessarily truncated
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 15:47 PDT by Aditya Keerthi
Modified: 2021-05-20 19:37 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.48 KB, patch)
2021-05-20 15:49 PDT, Aditya Keerthi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-05-20 15:47:47 PDT
...
Comment 1 Aditya Keerthi 2021-05-20 15:48:03 PDT
<rdar://problem/76008154>
Comment 2 Aditya Keerthi 2021-05-20 15:49:46 PDT
Created attachment 429234 [details]
Patch
Comment 3 Tim Horton 2021-05-20 17:02:06 PDT
Comment on attachment 429234 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429234&action=review

> Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477
> +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)

I think you want a WK prefix here? Or maybe it's OK and the compiler won't whine if it has the real one because it's a #define?

Also, does UIKit ignore the random flag bit if it /doesn't/ have this change?
Comment 4 Aditya Keerthi 2021-05-20 19:15:03 PDT
(In reply to Tim Horton from comment #3)
> Comment on attachment 429234 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429234&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm:477
> > +#define UIMenuOptionsPrivateRemoveLineLimitForChildren (1 << 6)
> 
> I think you want a WK prefix here? Or maybe it's OK and the compiler won't
> whine if it has the real one because it's a #define?

Yeah, it's fine because it's a #define. (Wenson suggested this approach)

> Also, does UIKit ignore the random flag bit if it /doesn't/ have this change?

It's ignored. I verified the change has no effect if the corresponding UIKit change is not present.
Comment 5 EWS 2021-05-20 19:37:50 PDT
Committed r277846 (237988@main): <https://commits.webkit.org/237988@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429234 [details].