Bug 226042 - Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos
Summary: Video player enters a bad state after trying to enter picture-in-picture on Y...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 14:23 PDT by Peng Liu
Modified: 2021-05-21 14:12 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.10 KB, patch)
2021-05-20 14:28 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2021-05-20 14:23:30 PDT 
Video player enters a bad state after trying to enter picture-in-picture on YouTube.com videos
Comment 1 Peng Liu 2021-05-20 14:27:54 PDT 
<rdar://76733650>
Comment 2 Peng Liu 2021-05-20 14:28:16 PDT 
Created attachment 429222 [details]
Patch
Comment 3 Daniel Bates 2021-05-21 10:52:21 PDT 
Comment on attachment 429222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429222&action=review

> Source/WebCore/ChangeLog:9
> +        always true. This patch fixes that.

Consider explaining about std::optional
Comment 4 EWS 2021-05-21 14:12:29 PDT 
Committed r277886 (238023@main): <https://commits.webkit.org/238023@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429222 [details].