Bug 226040 – Replace more static Locks with CheckedLocks in WTF / WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Chris Dumez]

Replace more static Locks with CheckedLocks so that we can benefit from Clang Thread Safety Analysis.

[Chris Dumez]

Created attachment 429218 [details]
Patch

[Darin Adler]

Comment on attachment 429218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review

Not enough time to review it all right now, but one comment.

> Source/WTF/wtf/Language.cpp:98
> -    preferredLanguagesOverride() = override;
> +    {
> +        Locker locker { preferredLanguagesOverrideLock };
> +        preferredLanguagesOverride() = override;
> +    }

Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this?

[Chris Dumez]

Comment on attachment 429218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429218&action=review

>> Source/WTF/wtf/Language.cpp:98
>> +    }
> 
> Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this?

Yes, it is fixing a bug that was found by clang thanks to adopting CheckedLock. Yes, the CheckedLock patches I have landed include some fixes but not many. Mostly our code was correct (Thankfully).

[Chris Dumez]

(In reply to Chris Dumez from comment #3)
> Comment on attachment 429218 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=429218&action=review
> 
> >> Source/WTF/wtf/Language.cpp:98
> >> +    }
> > 
> > Is this fixing a bug? Have you been mixing in fixes with the "refactor to use the checker" patches before this?
> 
> Yes, it is fixing a bug that was found by clang thanks to adopting
> CheckedLock. Yes, the CheckedLock patches I have landed include some fixes
> but not many. Mostly our code was correct (Thankfully).

I have split this fix to Bug 226059 to make it more obvious.

[Chris Dumez]

Created attachment 429249 [details]
Patch

[Chris Dumez]

Created attachment 429254 [details]
Patch

[Chris Dumez]

Created attachment 429256 [details]
Patch

[Chris Dumez]

Ok, I believe I have extracted all non-trivial bug fixes out into their own patches (see related bugs).

[Chris Dumez]

Created attachment 429308 [details]
Patch

[Chris Dumez]

*** Bug 226092 has been marked as a duplicate of this bug. ***

[Chris Dumez]

Created attachment 429311 [details]
Patch

[EWS]

Committed r277880 (238018@main): <https://commits.webkit.org/238018@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429311 [details].

[Radar WebKit Bug Importer]

<rdar://problem/78324905>