WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22604
Add test to ensure that an onload handler named 'onload' is called properly
https://bugs.webkit.org/show_bug.cgi?id=22604
Summary
Add test to ensure that an onload handler named 'onload' is called properly
Pam Greene (IRC:pamg)
Reported
2008-12-02 14:45:54 PST
Another test.
Attachments
New test + result
(1.68 KB, patch)
2008-12-02 14:51 PST
,
Pam Greene (IRC:pamg)
darin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Pam Greene (IRC:pamg)
Comment 1
2008-12-02 14:51:28 PST
Created
attachment 25684
[details]
New test + result This test is not well suited to the JS wrapper because of the onload handler.
Alexey Proskuryakov
Comment 2
2008-12-03 06:47:36 PST
Is this the same as fast/dom/Element/onclick-case.html?
> This test is not well suited to the JS wrapper because of the onload handler.
It is also smaller and better because is doesn't use the JS wrapper - I don't think there's any reason at all to use js-test-pre and friends in this case.
Darin Adler
Comment 3
2008-12-04 09:23:47 PST
Comment on
attachment 25684
[details]
New test + result r=me
Alexey Proskuryakov
Comment 4
2008-12-04 10:01:52 PST
It still seems to me that this test doesn't check for anything that isn't already checked for by fast/dom/Element/onclick-case.html.
Pam Greene (IRC:pamg)
Comment 5
2008-12-04 10:20:06 PST
Only that onload isn't necessarily the same code path as onclick, demonstrated by the fact that at one point Chromium passed the onclick test but failed this one.
Alexey Proskuryakov
Comment 6
2008-12-04 11:26:01 PST
OK - this wasn't mentioned before, and the fix for onclick was totally generic.
Pam Greene (IRC:pamg)
Comment 7
2008-12-05 15:59:33 PST
Landed
r39052
Right -- these tests are all part of the Chromium batch, so at some point Chromium passed everything else (that existed at the time) but failed this check. Sorry for any confusion about that.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug