Bug 22604 - Add test to ensure that an onload handler named 'onload' is called properly
Summary: Add test to ensure that an onload handler named 'onload' is called properly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pam Greene (IRC:pamg)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-02 14:45 PST by Pam Greene (IRC:pamg)
Modified: 2008-12-05 15:59 PST (History)
1 user (show)

See Also:


Attachments
New test + result (1.68 KB, patch)
2008-12-02 14:51 PST, Pam Greene (IRC:pamg)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pam Greene (IRC:pamg) 2008-12-02 14:45:54 PST
Another test.
Comment 1 Pam Greene (IRC:pamg) 2008-12-02 14:51:28 PST
Created attachment 25684 [details]
New test + result

This test is not well suited to the JS wrapper because of the onload handler.
Comment 2 Alexey Proskuryakov 2008-12-03 06:47:36 PST
Is this the same as fast/dom/Element/onclick-case.html?

> This test is not well suited to the JS wrapper because of the onload handler.

It is also smaller and better because is doesn't use the JS wrapper - I don't think there's any reason at all to use js-test-pre and friends in this case.
Comment 3 Darin Adler 2008-12-04 09:23:47 PST
Comment on attachment 25684 [details]
New test + result

r=me
Comment 4 Alexey Proskuryakov 2008-12-04 10:01:52 PST
It still seems to me that this test doesn't check for anything that isn't already checked for by fast/dom/Element/onclick-case.html.
Comment 5 Pam Greene (IRC:pamg) 2008-12-04 10:20:06 PST
Only that onload isn't necessarily the same code path as onclick, demonstrated by the fact that at one point Chromium passed the onclick test but failed this one.
Comment 6 Alexey Proskuryakov 2008-12-04 11:26:01 PST
OK - this wasn't mentioned before, and the fix for onclick was totally generic.
Comment 7 Pam Greene (IRC:pamg) 2008-12-05 15:59:33 PST
Landed r39052

Right -- these tests are all part of the Chromium batch, so at some point Chromium passed everything else (that existed at the time) but failed this check.  Sorry for any confusion about that.