Bug 226036 - Allow GPU process log channels to be configured
Summary: Allow GPU process log channels to be configured
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 12:19 PDT by Eric Carlson
Modified: 2021-05-21 09:06 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.67 KB, patch)
2021-05-20 12:46 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (6.69 KB, patch)
2021-05-20 13:18 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-05-20 12:19:53 PDT 
Allow GPU process log channels to be configured
Comment 1 Radar WebKit Bug Importer 2021-05-20 12:20:07 PDT 
<rdar://problem/78271211>
Comment 2 Eric Carlson 2021-05-20 12:46:53 PDT 
Created attachment 429208 [details]
Patch
Comment 3 Jer Noble 2021-05-20 13:09:35 PDT 
Comment on attachment 429208 [details]
Patch

r=me. I'm not entirely sure that the GPUProcessConnection will always have been created at the point where logging is configured. We may also need to add something at GPUProcessConnection time.
Comment 4 Eric Carlson 2021-05-20 13:18:53 PDT 
Created attachment 429211 [details]
Patch
Comment 5 Eric Carlson 2021-05-20 15:48:01 PDT 
(In reply to Jer Noble from comment #3)
> Comment on attachment 429208 [details]
> Patch
> 
> r=me. I'm not entirely sure that the GPUProcessConnection will always have
> been created at the point where logging is configured. We may also need to
> add something at GPUProcessConnection time.

Lets land this as-is and talk about whether or not that is worth the effort.
Comment 6 EWS 2021-05-20 16:06:10 PDT 
Committed r277835 (237979@main): <https://commits.webkit.org/237979@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429211 [details].
Comment 7 Simon Fraser (smfr) 2021-05-20 16:13:40 PDT 
For WebContent we send the logging channels via WebProcessCreationParameters. Can we do something similar for GPUP?
Comment 8 Eric Carlson 2021-05-21 09:06:25 PDT 
(In reply to Simon Fraser (smfr) from comment #7)
> For WebContent we send the logging channels via
> WebProcessCreationParameters. Can we do something similar for GPUP?

That's a good idea for configuration at launch, but we also need this for on the fly configuration via the Web Inspector.