Bug 226030 - Move off UIKit IPI in WKMouseGestureRecognizer
Summary: Move off UIKit IPI in WKMouseGestureRecognizer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-20 11:00 PDT by Tim Horton
Modified: 2021-05-20 12:59 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2021-05-20 11:01 PDT, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (3.26 KB, patch)
2021-05-20 11:11 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.28 KB, patch)
2021-05-20 11:16 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (3.31 KB, patch)
2021-05-20 11:24 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-05-20 11:00:41 PDT 
Move off UIKit IPI in WKMouseGestureRecognizer
Comment 1 Tim Horton 2021-05-20 11:01:14 PDT 
Created attachment 429189 [details]
Patch
Comment 2 Tim Horton 2021-05-20 11:01:16 PDT 
<rdar://problem/78266173>
Comment 3 Devin Rousso 2021-05-20 11:10:28 PDT 
Comment on attachment 429189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429189&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1662
> +    if (gestureRecognizer == _mouseGestureRecognizer)

NIT: Can we merge this with the above `if`?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1687
> +    return gestureRecognizer != _mouseGestureRecognizer;

I think this needs to be in `#if HAVE(UIKIT_WITH_MOUSE_SUPPORT)`.
Comment 4 Wenson Hsieh 2021-05-20 11:10:37 PDT 
Comment on attachment 429189 [details]
Patch

r=mews (once the watch/tv builds are fixed)
Comment 5 Tim Horton 2021-05-20 11:11:43 PDT 
Created attachment 429193 [details]
Patch
Comment 6 Tim Horton 2021-05-20 11:16:27 PDT 
Created attachment 429195 [details]
Patch
Comment 7 Tim Horton 2021-05-20 11:24:51 PDT 
Created attachment 429196 [details]
Patch
Comment 8 Devin Rousso 2021-05-20 12:04:34 PDT 
Comment on attachment 429196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429196&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1660
> -    if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch)
> -        return NO;
> +    if ([_mouseGestureRecognizer mouseTouch] == touch)
> +        return gestureRecognizer == _mouseGestureRecognizer;

Thinking about this a bit more, I think you actually had it correct to have separate `if` for this as right now this won't `return NO;` in the case that `gestureRecognizer == _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] != touch`.  Sorry for the trouble 😅
Comment 9 Tim Horton 2021-05-20 12:34:34 PDT 
Oh dear, you're right
Comment 10 EWS 2021-05-20 12:59:42 PDT 
Committed r277820 (237966@main): <https://commits.webkit.org/237966@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429195 [details].