Bug 226030 – Move off UIKit IPI in WKMouseGestureRecognizer

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Move off UIKit IPI in WKMouseGestureRecognizer

[Tim Horton]

Created attachment 429189 [details]
Patch

[Tim Horton]

<rdar://problem/78266173>

[Devin Rousso]

Comment on attachment 429189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429189&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1662
> +    if (gestureRecognizer == _mouseGestureRecognizer)

NIT: Can we merge this with the above `if`?

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1687
> +    return gestureRecognizer != _mouseGestureRecognizer;

I think this needs to be in `#if HAVE(UIKIT_WITH_MOUSE_SUPPORT)`.

[Wenson Hsieh]

Comment on attachment 429189 [details]
Patch

r=mews (once the watch/tv builds are fixed)

[Tim Horton]

Created attachment 429193 [details]
Patch

[Tim Horton]

Created attachment 429195 [details]
Patch

[Tim Horton]

Created attachment 429196 [details]
Patch

[Devin Rousso]

Comment on attachment 429196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=429196&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1660
> -    if (gestureRecognizer != _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] == touch)
> -        return NO;
> +    if ([_mouseGestureRecognizer mouseTouch] == touch)
> +        return gestureRecognizer == _mouseGestureRecognizer;

Thinking about this a bit more, I think you actually had it correct to have separate `if` for this as right now this won't `return NO;` in the case that `gestureRecognizer == _mouseGestureRecognizer && [_mouseGestureRecognizer mouseTouch] != touch`.  Sorry for the trouble 😅

[Tim Horton]

Oh dear, you're right

[EWS]

Committed r277820 (237966@main): <https://commits.webkit.org/237966@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429195 [details].